-
Notifications
You must be signed in to change notification settings - Fork 247
Cache ghc883 and ghc8101 again (without tests) #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When ghc 8.8.4 and ghc 8.10.2 were added we stopped building the older versions on ci. This changes adds them back but does not run all the tests on them.
ci.nix
Outdated
inherit (import ./default.nix { inherit checkMaterialization; }) nixpkgsArgs; | ||
inherit runTests; | ||
}) ({ | ||
ghc865 = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth writing down the policy here... what is it?
Actually, thinking about the policy, should we put something in the documentation (and maybe even in the readme) listing the GHC versions that get this extra level of support? I think it's just two support levels:
Writing it down, I guess that's only one level as far as users are concerned. |
@michaelpj I think that would be a good idea. Additionally, I'm not sure if it's too much trouble, but getting the CI to maintain some system of tags/branches which allows a user to get the latest version of haskell.nix for which cached builds are available with a particular compiler and nixpkgs would be very useful. At the moment the choice is between sitting on one fixed commit forever once you've finally got everything to work, or upgrading straight to master periodically (which can often cause breakages with a selected combination of nixpkgs, compiler and index-state). |
I think realistically the only guarantee we offer is that master is built with whatever's in |
@michaelpj The problem I'm running into is that it doesn't seem like we have the guarantee that everything in ci.nix is built by the time it's in master. I want some ref that I can put in my niv projects, such that when I run |
Are you using the iohk hydra cache as well as the cachix one? (https://input-output-hk.github.io/haskell.nix/tutorials/getting-started/#setting-up-the-cachix-binary-cache) |
When ghc 8.8.4 and ghc 8.10.2 were added we stopped building the older versions on ci. This changes adds them back but does not run all the tests on them.
When ghc 8.8.4 and ghc 8.10.2 were added we stopped building the older
versions on ci. This changes adds them back but does not run all
the tests on them.