Fix dependency filtering for shellFor
#819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to refactor this a bit to understand what was going on, but the kicker is two changes: - `removeSelectedInput` was only removing *library* components. This was fine when we were only looking at the `all` components, since they always dependend on libraries. But now we're looking at all kinds of components, and these can, for example, depend on internal libraries. So we need to filter out dependencies on *any* component, not just a library component. This fixes #818 - The filtering on `nativeBuildInputs` was wrong, since it was using the filtering function that filters *packages*, not the one that filters *derivations*. I didn't observe this causing a bug but it seems wrong.
booniepepper
pushed a commit
to booniepepper/haskell.nix
that referenced
this pull request
Feb 4, 2022
I had to refactor this a bit to understand what was going on, but the kicker is two changes: - `removeSelectedInput` was only removing *library* components. This was fine when we were only looking at the `all` components, since they always dependend on libraries. But now we're looking at all kinds of components, and these can, for example, depend on internal libraries. So we need to filter out dependencies on *any* component, not just a library component. This fixes input-output-hk#818 - The filtering on `nativeBuildInputs` was wrong, since it was using the filtering function that filters *packages*, not the one that filters *derivations*. I didn't observe this causing a bug but it seems wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this got broken in #776 when we changed to working with individual components. Have a look, I don't really know what I'm doing here. I expanded the comment to hopefully make it clear.
I had to refactor this a bit to understand what was going on, but the
kicker is two changes:
removeSelectedInputwas only removing library components. This wasfine when we were only looking at the
allcomponents, since theyalways dependend on libraries. But now we're looking at all kinds of
components, and these can, for example, depend on internal libraries.
So we need to filter out dependencies on any component, not just a
library component. This fixes
shellFordepends on some of the selected packages #818nativeBuildInputswas wrong, since it was using thefiltering function that filters packages, not the one that filters
derivations. I didn't observe this causing a bug but it seems wrong.