Allow order independent overlays #2043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the haskell.nix overlays ignore any `defaultModules` and `extraPkgconfigMappings` set in `prev`. This means it is not possible to have an overly include these in an way that will work both before and after the haskell.nix overlays.
With this change an overlay can be written like this:
```
final: prev: {
haskell-nix = prev.haskell-nix or {} // {
extraPkgconfigMappings = prev.haskell-nix.extraPkgconfigMappings or {} // {
...
```
It can then be included before or after the haskell.nix overlays.
hamishmack
added a commit
to input-output-hk/iohk-nix
that referenced
this pull request
Sep 1, 2023
Take advantage of input-output-hk/haskell.nix#2043 to allow the haskell-nix-crypto overlay to come before or after the haskell.nix overlays.
hamishmack
added a commit
to input-output-hk/iohk-nix
that referenced
this pull request
Sep 1, 2023
Take advantage of input-output-hk/haskell.nix#2043 to allow the haskell-nix-crypto overlay to come before or after the haskell.nix overlays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the haskell.nix overlays ignore any
defaultModulesandextraPkgconfigMappingsset inprev. This means it is not possible to have an overly include these in an way that will work both before and after the haskell.nix overlays.With this change an overlay can be written like this:
It can then be included before or after the haskell.nix overlays.
See #1954