Skip to content

Remove flake utils #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Sep 5, 2023
Merged

Remove flake utils #2027

merged 25 commits into from
Sep 5, 2023

Conversation

andreabedini
Copy link
Member

Trying to tidy up the top level flake.

I have checked that 5f00c25 does not change any derivation iun hydraJobs (excluding the ones depending on the git rev).

Marking it as draft because this probably makes evaluation worse as it re-evaluates

self.internal.compat { inherit system; })

many times. I need to factor that out (likely merging/replacing it with legacyPackages).

@andreabedini andreabedini self-assigned this Aug 18, 2023
Copy link
Collaborator

@hamishmack hamishmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have one less dependency, but it would be better if we had a solution that also worked for examples and code templates using haskell.nix. Until then I think perhaps we should at keep the flake-utils input (so as not to break existing code that follows it). Perhaps we could still avoid using flake-utils in flake.nix, if you think it is more readable.

@angerman
Copy link
Collaborator

We can at least go back to upstream for now numtide/flake-utils#97.

@hamishmack
Copy link
Collaborator

Now we can advise people to switch to inputs.flake-utils.url = "github:numtide/flake-utils". No need to keep the input for .follows support (unless there is a better option coming).

@andreabedini andreabedini marked this pull request as ready for review September 4, 2023 08:52
@andreabedini
Copy link
Member Author

This ended up being quite of a work of the main nix entrypoints (flake.nix, default.nix, shell.nix and ci.nix).
Everything is mostly flake.nix centric now, and default.nix tries its best to maintain compatibility with the pre-flake default.nix.

@hamishmack hamishmack merged commit 1b4bccb into master Sep 5, 2023
@andreabedini andreabedini deleted the remove-flake-utils branch September 5, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants