-
Notifications
You must be signed in to change notification settings - Fork 247
Remove some obsolete hackage-quirks #1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ugh, looks like the plugins don't actually work? I'm very confused, I thought people were able to install HLS from source fine, which should have not worked if the plugins weren't set up properly. But indeed HLS depends on |
Okay, got the revision in. So we probably just need to wait for |
d4bd2ac
to
b4bca40
Compare
The `stlylish-haskell` plugin is updated and there was a `retrie` release.
b4bca40
to
ed18191
Compare
Rebased on master |
hls-hlint-plugin, hls-stan-plugin, hls-rename-plugin and hls-qualify-imported-names failed to build. Perhaps we should bump the internal index state but I have materialisation nightmares :D |
Why does this now remove the hls 1.9.0.0 work arounds? Those are new aren't they? |
It looks like the ghc 9.4.3 ci jobs (the only ones use hls 1.9) are all working. So hackage issue must have been fixed. We just need to figure out why 1.8 is not building on the older GHC versions that still use it.
hls build in CI does not set an index state or use materialised nix. So it picks up the latest hackage index-state available in hackage.nix. |
BTW logic choosing HLS version to build on CI is here Lines 47 to 49 in ee6e1d7
|
The
stlylish-haskell
plugin is updated and there was aretrie
release.