Skip to content

Remove some obsolete hackage-quirks #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Conversation

michaelpj
Copy link
Collaborator

The stlylish-haskell plugin is updated and there was a retrie
release.

@michaelpj
Copy link
Collaborator Author

Ugh, looks like the plugins don't actually work? I'm very confused, I thought people were able to install HLS from source fine, which should have not worked if the plugins weren't set up properly. But indeed HLS depends on hls-plugin-api >= 1.5 and hls-stylish-haskell-plugin has hls-plugin-api <1.5

@hamishmack
Copy link
Collaborator

@michaelpj
Copy link
Collaborator Author

Okay, got the revision in. So we probably just need to wait for hackage.nix to update and then we can try this again.

@michaelpj michaelpj force-pushed the mpj/remove-hls-quirks branch from d4bd2ac to b4bca40 Compare December 16, 2022 12:18
The `stlylish-haskell` plugin is updated and there was a `retrie`
release.
@andreabedini andreabedini force-pushed the mpj/remove-hls-quirks branch from b4bca40 to ed18191 Compare January 24, 2023 02:39
@andreabedini
Copy link
Member

Rebased on master

@andreabedini
Copy link
Member

hls-hlint-plugin, hls-stan-plugin, hls-rename-plugin and hls-qualify-imported-names failed to build. Perhaps we should bump the internal index state but I have materialisation nightmares :D

@hamishmack
Copy link
Collaborator

Why does this now remove the hls 1.9.0.0 work arounds? Those are new aren't they?

@hamishmack
Copy link
Collaborator

It looks like the ghc 9.4.3 ci jobs (the only ones use hls 1.9) are all working. So hackage issue must have been fixed.

We just need to figure out why 1.8 is not building on the older GHC versions that still use it.

hls-hlint-plugin, hls-stan-plugin, hls-rename-plugin and hls-qualify-imported-names failed to build. Perhaps we should bump the internal index state but I have materialisation nightmares :D

hls build in CI does not set an index state or use materialised nix. So it picks up the latest hackage index-state available in hackage.nix.

@hamishmack
Copy link
Collaborator

BTW logic choosing HLS version to build on CI is here

haskell.nix/build.nix

Lines 47 to 49 in ee6e1d7

if __compareVersions haskell.compiler.${compiler-nix-name}.version "9.4" < 0
then "1.8.0.0"
else "latest";

@hamishmack hamishmack merged commit 1c89ec4 into master Jan 24, 2023
@iohk-bors iohk-bors bot deleted the mpj/remove-hls-quirks branch January 24, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants