Update the project modules and fix missing args param #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryTimed out. |
|
Hydra did finish ok in the end. |
booniepepper
pushed a commit
to booniepepper/haskell.nix
that referenced
this pull request
Feb 4, 2022
…k#1144) There are now 4 project modules used to check the arguments passed to the various project functions: * `project-common.nix` - Arguments used by all the project functions * `stack-project.nix` - Used by the `stackProject` and `stackProject'` functions * `cabal-project.nix` - Used by the `cabalProject` and `cabalProject'` functions * `project.nix` - Just the `projectFileName` argument that is used by `project` and `project'` functions to determine whether to call `stackProject` or `cabalProject` function. This also includes the `rawProject.args` that was mistakenly left out of input-output-hk#1141 causing input-output-hk#1142 and improvements for the docs for the use of the `shell` argument in `flake.nix` files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are now 4 project modules used to check the arguments passed to the various project functions:
project-common.nix- Arguments used by all the project functionsstack-project.nix- Used by thestackProjectandstackProject'functionscabal-project.nix- Used by thecabalProjectandcabalProject'functionsproject.nix- Just theprojectFileNameargument that is used byprojectandproject'functions to determine whether to callstackProjectorcabalProjectfunction.This also includes the
rawProject.argsthat was mistakenly left out of #1141 causing #1142 and improvements for the docs for the use of theshellargument inflake.nixfiles.