Switch from cabal 3.2 to 3.4 #1058
Conversation
|
Does nix-tools need a version bounds relaxation too? I don't know what happens if we have a |
Yes, we should update that too.
I think it would be fine as long as the |
|
bors try |
|
bors try- |
|
bors try |
tryBuild failed: |
|
bors try |
tryTimed out. |
|
bors try |
| @@ -22,6 +22,9 @@ in { haskell-nix = prev.haskell-nix // { | |||
| # Version of of cabal-install in hackage is broken for GHC 8.10.1 | |||
| (lib.optionalAttrs (version == "3.2.0.0") { | |||
| packages.cabal-install.src = final.haskell-nix.sources.cabal-32 + "/cabal-install"; | |||
| }) | |||
| (lib.optionalAttrs (builtins.compareVersions version "3.0.0.0" >= 0 | |||
| && builtins.compareVersions version "3.5" < 0) { | |||
There was a problem hiding this comment.
Don’t we have Greater than, ge, le, lt functions? I think that would make this a lot more readable.
There was a problem hiding this comment.
Maybe I am just old shcool, but I think the strcmp rule is ok. Always compare to 0 that way:
x op y <=> x y op 0
tryBuild succeeded: |
|
@hamishmack I don't really understand the infrastructure that well, but is it possible that something was missed here: ? When I depend on the |
No description provided.