feat: simrevert type #98
Open
+134
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dylanlott
force-pushed
the
dylan/submit-channel-refactors
branch
4 times, most recently
from
0a3a830 to
0e8eda5
Compare
dylanlott
changed the base branch from
dylan/submit-channel-refactors
to
graphite-base/98
dylanlott
force-pushed
the
graphite-base/98
branch
from
0e8eda5 to
1fc9892
Compare
dylanlott
force-pushed
the
prestwich/simrevert
branch
2 times, most recently
from
f516bc0 to
91b328f
Compare
dylanlott
force-pushed
the
prestwich/simrevert
branch
from
2c09604 to
a96a88f
Compare
dylanlott
approved these changes
Jun 4, 2025
Evalir
reviewed
Jun 5, 2025
| /// Incorrect host block error | ||
| IncorrectHostBlock, | ||
| /// Bad signature error | ||
| BadSignature, |
There was a problem hiding this comment.
I assume we're not preserving the data in tihs error since it's probably not worth it do so anyway
There was a problem hiding this comment.
it's an error kind not an error itself. it's just a memoization of the type of the actual error data stored elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a revert error convenience type to clean up some code and encapsulate our error munging