-
Notifications
You must be signed in to change notification settings - Fork 0
updates bundler to streaming actor pattern #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates bundler to streaming actor pattern #61
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e815024
to
da16b28
Compare
da16b28
to
6d96ba0
Compare
8b1ec06
to
aaeb7c6
Compare
14c9300
to
154904b
Compare
aaeb7c6
to
aff2cdf
Compare
8ad95f6
to
962eaa1
Compare
aff2cdf
to
5069931
Compare
83382b4
to
47b29f7
Compare
5069931
to
1ad6e14
Compare
47b29f7
to
fa6109b
Compare
b9b7887
to
01a11e6
Compare
use oauth2::TokenResponse; | ||
use reqwest::Url; | ||
use serde::{Deserialize, Serialize}; | ||
use std::collections::HashMap; | ||
use std::time::{Duration, Instant}; | ||
use tokio::sync::mpsc::{UnboundedReceiver, UnboundedSender, unbounded_channel}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: couldn't we unify these imports?
Updates builder to streaming actor pattern
The block builder was previously just calling the fetch function from the bundle service. Instead, this PR makes it so that bundles are streamed out from the cache to a simulator task that processes and builds them into a valid block.
Closes ENG-791