Skip to content

updates bundler to streaming actor pattern #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Mar 17, 2025

Updates builder to streaming actor pattern

The block builder was previously just calling the fetch function from the bundle service. Instead, this PR makes it so that bundles are streamed out from the cache to a simulator task that processes and builds them into a valid block.

Closes ENG-791

Copy link
Contributor Author

dylanlott commented Mar 17, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dylanlott dylanlott marked this pull request as ready for review March 17, 2025 01:19
@dylanlott dylanlott force-pushed the 03-16-updates_bundler_to_streaming_actor_pattern branch from e815024 to da16b28 Compare March 17, 2025 01:23
@dylanlott dylanlott self-assigned this Mar 17, 2025
@dylanlott dylanlott added the enhancement New feature or request label Mar 17, 2025 — with Graphite App
@dylanlott dylanlott force-pushed the 03-16-updates_bundler_to_streaming_actor_pattern branch from da16b28 to 6d96ba0 Compare March 17, 2025 18:37
@dylanlott dylanlott force-pushed the 03-07-updates_the_tx-poller_to_stream_transactions branch from 8b1ec06 to aaeb7c6 Compare March 17, 2025 18:48
@dylanlott dylanlott force-pushed the 03-16-updates_bundler_to_streaming_actor_pattern branch 2 times, most recently from 14c9300 to 154904b Compare March 18, 2025 16:31
@dylanlott dylanlott force-pushed the 03-07-updates_the_tx-poller_to_stream_transactions branch from aaeb7c6 to aff2cdf Compare March 19, 2025 15:59
@dylanlott dylanlott force-pushed the 03-16-updates_bundler_to_streaming_actor_pattern branch 2 times, most recently from 8ad95f6 to 962eaa1 Compare March 19, 2025 16:25
@dylanlott dylanlott force-pushed the 03-07-updates_the_tx-poller_to_stream_transactions branch from aff2cdf to 5069931 Compare March 27, 2025 20:46
@dylanlott dylanlott force-pushed the 03-16-updates_bundler_to_streaming_actor_pattern branch from 83382b4 to 47b29f7 Compare March 27, 2025 20:46
@dylanlott dylanlott force-pushed the 03-07-updates_the_tx-poller_to_stream_transactions branch from 5069931 to 1ad6e14 Compare April 3, 2025 19:06
@dylanlott dylanlott force-pushed the 03-16-updates_bundler_to_streaming_actor_pattern branch from 47b29f7 to fa6109b Compare April 3, 2025 19:06
dylanlott and others added 4 commits April 8, 2025 14:27
- improves poll interval handling
- cleans up and updates comments
- removes arc usage
@dylanlott dylanlott force-pushed the 03-16-updates_bundler_to_streaming_actor_pattern branch from b9b7887 to 01a11e6 Compare April 8, 2025 20:30
use oauth2::TokenResponse;
use reqwest::Url;
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::time::{Duration, Instant};
use tokio::sync::mpsc::{UnboundedReceiver, UnboundedSender, unbounded_channel};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: couldn't we unify these imports?

@dylanlott dylanlott closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants