Skip to content

chore: use bin base #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2025
Merged

chore: use bin base #55

merged 4 commits into from
Feb 18, 2025

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Feb 18, 2025

use init4() to set up metrics and tracing
bring crate in line with clippy and code standards policies in other repos


tracing::trace!("installing metrics collector");
PrometheusBuilder::new().install().expect("failed to install prometheus exporter");
init4();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love it

@prestwich
Copy link
Member Author

dont merge yet still migrating some stuff

@Evalir
Copy link
Member

Evalir commented Feb 18, 2025

all good the author always merges, home rule

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a description to the PR that tells what this is for? for posterity, since there are a lot of somewhat unrelated changes :).

@prestwich prestwich merged commit ac0491c into main Feb 18, 2025
4 checks passed
@prestwich prestwich deleted the prestwich/bin-base branch February 18, 2025 20:02
@prestwich prestwich mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants