-
Notifications
You must be signed in to change notification settings - Fork 524
Add Example for sending information to DB via UDP #648
Conversation
Due to lack of documentation for UDP, this example provides basic usage of sending information points via UDP. The code structure followed is similar, if not same as other examples in the `examples` directory. Locally tested with: InfluxDB v1.6.1 on Windows10 and influxdb-python v5.0.0 and should not break anything Signed-off-by: Shantanoo <shantanoo.desai@gmail.com>
@aviau Any suggestions on how to overcome the failed tests? |
It looks like travis's pypy plugin is broken. I would probably merge a PR that disables pypy for now. |
Should I change the |
Yes, someone should do it. That would be in a separate pull request. |
Please finish the task |
- This commit adds the `tutorial_udp.py`'s Documentation to the existing documentation sourcecode. Signed-off-by: Shantanoo <shantanoo.desai@gmail.com>
- Travis Build 1500.37 failed for: `Python3.6 and TOX_ENV=pep257` - Improve Docstring within code to overcome build error Signed-off-by: Shantanoo <shantanoo.desai@gmail.com>
@nevmerzhitsky @aviau @xginn8 Travis tests have passed on the documentations. I however want to address that during the I have already resolved the Issue and wanted to know if this should be on a different PR or should I push the code here? |
@xginn8 The changes you requested were already addressed in the PR. The ports for UDP is |
@shantanoo-desai I think it makes more sense to pass the UDP port as an arg, rather than the TCP port used to connect to InfluxDB. You can omit the hostname and TCP port altogether if you want to make it more clear. Also, please push any other fixes unrelated to this example in a separate PR. |
- Instead of providing arguments of HTTP InfluxDB, provide UDP Port as argument - Improve the Comments to distinguish between different UDP Ports (e.g. 8089(default) saves to `udp1` and 8090 saves to `udp2` databases respectively Signed-off-by: Shantanoo <shantanoo.desai@gmail.com>
@xginn8 As mentioned, I have improved the |
thanks for contributing @shantanoo-desai!! |
Due to lack of documentation for UDP, this example provides basic usage of sending information points via UDP. The code structure followed is similar, if not same as other examples in the `examples` directory. Signed-off-by: Shantanoo <shantanoo.desai@gmail.com>
Due to lack of documentation for UDP, this example provides basic usage of sending information points via UDP. The code structure followed is similar, if not same as other examples in the `examples` directory. Signed-off-by: Shantanoo <shantanoo.desai@gmail.com>
Too bad this part of the updated docs seems not to have been integrated into the online doc : https://influxdb-python.readthedocs.io/en/latest/examples.html |
@xginn8 Is there something I need to do to show this example on the Docs? I think I executed all necessary steps in the PR for Sphinx |
@shantanoo-desai I'll take a look as to why it hasn't updated yet, thanks for the tip |
Due to lack of documentation for UDP, this example
provides basic usage of sending information points
via UDP. The code structure followed is similar, if
not same as other examples in the
examples
directory.Locally tested with:
InfluxDB v1.6.1 on Windows10 and influxdb-python v5.0.0
and should not break anything
Things To do
This PR addresses #646 #647
Signed-off-by: Shantanoo shantanoo.desai@gmail.com