Skip to content

Upgrade peer dependencies #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Conversation

thdk
Copy link
Contributor

@thdk thdk commented Aug 14, 2023

This is an attempt to fix #65

@infctr
Copy link
Owner

infctr commented Aug 14, 2023

@thdk thanks for the PR!
Can you have a look at failed checks? Bumping prettier might seem to help

@thdk
Copy link
Contributor Author

thdk commented Aug 16, 2023

Bumped prettier. Removed old eslint rule from jest plugin. Fixed eslint config to only use typescript eslint plugins for typescript files because it will otherwise fail on linting javascript files such as .eslintrc.js which are not included in a tsconfig.json file.

Now some tests still fail on:

  ● Test suite failed to run

    Cannot find module '@typescript-eslint/parser' from 'tests/helpers/configs.ts'

    Require stack:
      tests/helpers/configs.ts
      tests/rules/string-enum.spec.ts

       5 |
       6 | export const typescript: Linter.Config = {
    >  7 |   parser: require.resolve('@typescript-eslint/parser'),
         |                   ^
       8 |   parserOptions: {
       9 |     sourceType: 'module',
      10 |     project: path.join(__dirname, './tsconfig.json'),

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:322:11)
      at Object.<anonymous> (tests/helpers/configs.ts:7:19)
      at Object.<anonymous> (tests/rules/string-enum.spec.ts:5:1)

@thdk
Copy link
Contributor Author

thdk commented Aug 16, 2023

Upgraded jest to make tests work.

@deniskabana
Copy link

@infctr Can you please check this PR now? I ran into the same issue and was going to open the same PR :)

@infctr
Copy link
Owner

infctr commented Aug 30, 2023

Looks good!

@infctr
Copy link
Owner

infctr commented Aug 30, 2023

Published a new version

@cpojer
Copy link

cpojer commented Sep 5, 2023

Thanks so much for keeping this plugin fresh, I use it in all my projects and recommend it to everyone. It's part of @nkzw/eslint-config: https://github.com/cpojer/eslint-config.

@thdk thdk deleted the chore/upgrade-dependencies branch December 27, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@typescript-eslint/parser@"6.0.0" is out
4 participants