Skip to content

Support StackBlitz embed #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Support StackBlitz embed #176

merged 1 commit into from
Jun 13, 2025

Conversation

tsuzuki-takaaki
Copy link
Contributor

@tsuzuki-takaaki tsuzuki-takaaki commented Jun 11, 2025

Support StackBlitz embed.
You can embed StackBlitz with iframe like this:

<iframe src="https://stackblitz.com/edit/angular?embed=1"></iframe>

Refs

@tsuzuki-takaaki tsuzuki-takaaki self-assigned this Jun 11, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @tsuzuki-takaaki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the capability to embed StackBlitz projects directly into markdown content processed by this library. It involves adding a new module for StackBlitz configuration, updating the iframe filtering logic to permit StackBlitz URLs, and including corresponding tests to ensure the functionality works as expected.

Highlights

  • New Embed Support: Added support for embedding StackBlitz projects within markdown content by allowing iframes from stackblitz.com.
  • Module Structure: Introduced a new StackBlitz module under Qiita::Markdown::Embed to encapsulate configuration related to StackBlitz embeds, specifically its script host.
  • Iframe Filtering: Updated the FilterIframe transformer to include stackblitz.com in the list of allowed iframe sources, ensuring StackBlitz embeds are not stripped or modified by the filter.
  • Test Coverage: Added new test cases in processor_spec.rb to verify that iframes pointing to stackblitz.com/embed/... are correctly processed and allowed by the markdown processor, covering URLs with and without a scheme.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces support for StackBlitz embeds. I've suggested enhancing the test coverage by including initial attributes in the test case, which would provide a more comprehensive validation of attribute handling.

@tsuzuki-takaaki tsuzuki-takaaki force-pushed the support-stack-blitz-embed branch from badf46d to 3022aab Compare June 11, 2025 06:47
@tsuzuki-takaaki tsuzuki-takaaki marked this pull request as ready for review June 11, 2025 06:48
@tsuzuki-takaaki tsuzuki-takaaki requested review from a team and tomoasleep and removed request for a team June 11, 2025 06:55
@tsuzuki-takaaki tsuzuki-takaaki force-pushed the support-stack-blitz-embed branch from 3022aab to 7179dfa Compare June 11, 2025 08:08
@tsuzuki-takaaki tsuzuki-takaaki force-pushed the support-stack-blitz-embed branch from 7179dfa to 0bca641 Compare June 12, 2025 07:15
@tomoasleep tomoasleep merged commit 47bb82b into master Jun 13, 2025
8 checks passed
@tomoasleep tomoasleep deleted the support-stack-blitz-embed branch June 13, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants