Add port option to qiita.config.json #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getty104
requested review from
a team and
ohakutsu
and removed request for
a team
ohakutsu
reviewed
Jul 25, 2023
| @@ -30,9 +31,8 @@ export async function startServer() { | |||
| app.use("*", express.static(path.join(__dirname, "../public/index.html"))); | |||
|
|
|||
| const server = createServer(app); | |||
| const port = process.env.QIITA_CLI_PORT | |||
There was a problem hiding this comment.
PRに記載の通り、削除で良いかなと思っています
getty104
force-pushed
the
add-port-config
branch
from
b189266 to
ca46463
Compare
getty104
force-pushed
the
add-port-config
branch
from
ca46463 to
872d8d6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
qiita.config.jsonでポート番号を指定できるようにした。
portでポート番号を指定することができる（デフォルトは8888）環境変数でポート番号を指定することができる仕様を削除した。
Why
Refs