Improve error messages #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohakutsu
force-pushed
the
improve-error-message
branch
from
11fa9ca to
d88f68e
Compare
Screenshots認証が失敗した場合
portが空いていない場合
バリデーションエラー
|
 |
 |
ohakutsu
requested review from
a team and
getty104
and removed request for
a team
ohakutsu
force-pushed
the
improve-error-message
branch
from
d88f68e to
1d2131a
Compare
getty104
reviewed
Jul 26, 2023
src/commands/publish.ts
Outdated
Comment on lines
71
to
73
| let text = chalk.red.bold(`${msg.name}: `); | ||
| text += chalk.red(err); | ||
| console.error(text); |
There was a problem hiding this comment.
IMO&NITS
↓のような書き方の方が直感的に何をやっているかわかりやすいと感じました。
Suggested change
| let text = chalk.red.bold(`${msg.name}: `); | |
| text += chalk.red(err); | |
| console.error(text); | |
| const errorName = chalk.red.bold(msg.name); | |
| const errorDescription = chalk.red(err); | |
| console.error(`${errorName}: ${errorDescription}`) |
getty104
approved these changes
Jul 27, 2023
| invalidItemMessages.forEach((msg) => { | ||
| console.error(msg.name, msg.errors); | ||
| msg.errors.forEach((err) => { | ||
| const errorName = chalk.red.bold(msg.name + ":"); |
There was a problem hiding this comment.
nits
Suggested change
| const errorName = chalk.red.bold(msg.name + ":"); | |
| const errorName = chalk.red.bold(`${msg.name}:`); |
ohakutsu
force-pushed
the
improve-error-message
branch
from
a1d1368 to
9468550
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
エラー発生時のメッセージがわかりにくい（何をすればいいのかわからない。なぜエラーになっているのかわからない）ため、改善する。
How
Why
Refs