Check if local files are up to date #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohakutsu
requested review from
a team and
getty104
and removed request for
a team
getty104
reviewed
Jul 21, 2023
| @@ -17,9 +17,9 @@ export const pull = async (argv: string[]) => { | |||
|
|
|||
| const qiitaApi = await getQiitaApiInstance(); | |||
| const fileSystemRepo = await getFileSystemRepo(); | |||
| const isLocalUpdate = args["--force"]; | |||
| const forceUpdate = args["--force"]; | |||
There was a problem hiding this comment.
pull.tsとsync-article-from-qiita.tsの変数の命名変更は別文脈なのでコミット分けたいです 🙏
|
@ohakutsu エラーが出ている時のUIの画像を添付して欲しいです 🙏 |
ScreenshotsQiita Preview
CLI
|
ohakutsu
force-pushed
the
check-local-files-are-up-to-date
branch
from
7439b9b to
5b39357
Compare
getty104
reviewed
Jul 21, 2023
Comment on lines
272
to
277
| private async syncItem( | ||
| item: Item, | ||
| beforeSync: boolean = false, | ||
| isLocalUpdate: boolean = false | ||
| forceUpdate: boolean = false | ||
| ) { | ||
| const fileContent = FileContent.fromItem(item); |
There was a problem hiding this comment.
LGTMした後ですみません
テストは変更ないですが大丈夫ですか？
ohakutsu
force-pushed
the
check-local-files-are-up-to-date
branch
from
5b39357 to
c800d90
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
現在、Qiita上で記事を変更した場合に
pull --forceをしなければ、ローカルの記事ファイルが古い状態になってしまう可能性がある。→ Qiita上で変更したものが上書きされてしまい消えてしまう恐れがある。
そのため、Qiita上で記事が更新されているが、記事ファイルが古い状態になってしまっているときに注意を出すようにした。
How
Why
Refs