Scroll to top with page transition #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyntk
force-pushed
the
scroll-to-top-with-page-transition
branch
from
767a164 to
ea854e1
Compare
kyntk
commented
Jul 18, 2023
|
|
||
| ...viewport.S({ | ||
| gridTemplateColumns: "auto 1fr", | ||
| gridTemplateColumns: "auto minmax(0, 1fr)", // Setting min width to prevent widening |
There was a problem hiding this comment.
kyntk
requested review from
a team,
getty104 and
DeguchiHiroki
and removed request for
a team
getty104
approved these changes
Jul 18, 2023
| return ( | ||
| <div> | ||
| <Outlet /> | ||
| <ScrollRestoration /> |
There was a problem hiding this comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
window.scrollYが0になっているWhy
Refs
2023-07-18.17.52.47.mov