Skip to content

Add lint-staged #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add lint-staged #29

merged 1 commit into from
Jul 19, 2023

Conversation

ohakutsu
Copy link
Member

@ohakutsu ohakutsu commented Jul 14, 2023

What

lint-stagedを追加した

How

Why

Refs

@ohakutsu ohakutsu self-assigned this Jul 14, 2023
@@ -59,9 +60,11 @@
"dev:client": "webpack --watch",
"dev:server": "tsc --build --watch",
"dev": "run-p dev:*",
"format": "eslint --fix . && prettier --write .",
"format": "eslint --fix . && prettier --list-different --write .",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[memo]

フォーマットされたファイルのみ出力されるようにした

https://prettier.io/docs/en/cli.html#--list-different

"lint": "run-p lint:*",
"lint:prettier:fix": "prettier --list-different --ignore-unknown --write",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ohakutsu ohakutsu requested a review from getty104 July 14, 2023 12:37
getty104
getty104 previously approved these changes Jul 18, 2023
Copy link
Member

@getty104 getty104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ohakutsu
Copy link
Member Author

yarn.lockのコンフリクトがあったので解消しました!

@ohakutsu ohakutsu merged commit 6126a03 into main Jul 19, 2023
@ohakutsu ohakutsu deleted the add-lint-staged branch July 19, 2023 03:26
@ohakutsu ohakutsu mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants