Skip to content

Add package update notice #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add package update notice #28

merged 1 commit into from
Jul 19, 2023

Conversation

ohakutsu
Copy link
Member

@ohakutsu ohakutsu commented Jul 14, 2023 •
edited
Loading

What

最新のパッケージが公開されている場合に通知を出すようにした

How

  • npm registryから最新のバージョンを取得し、現在のバージョンと異なる場合に通知を出すようにした
    • npm registryから取得したバージョンは12時間キャッシュされる

Why

Refs

@ohakutsu ohakutsu self-assigned this Jul 14, 2023
@ohakutsu
Copy link
Member Author

ohakutsu commented Jul 14, 2023 •
edited
Loading

Screenshots

image

@ohakutsu ohakutsu requested a review from acronhub July 14, 2023 11:11
@acronhub
Copy link
Contributor

acronhub commented Jul 18, 2023 •
edited
Loading

nits

.envファイル`に追加したほうがいいかもしれないです

  • XDG_CACHE_HOME

acronhub
acronhub previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@acronhub acronhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメント書きました
プレビュー時の表示位置は、個人的には記事情報の上でもいいかも

動作には問題ないのでLGTM

@ohakutsu
Copy link
Member Author

プレビューをする際はコンソール上からqiitaコマンドを叩くため、Qiita Preview上にはなくても良いのではないかと考え外すことにしました！

@ohakutsu ohakutsu force-pushed the add-package-update-notice branch from 054c493 to ff38106 Compare July 18, 2023 05:39
@ohakutsu ohakutsu requested a review from acronhub July 18, 2023 05:41
acronhub
acronhub reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@acronhub acronhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントしました。
.env.sampleファイルの修正だけお願いいたします！！

.env.sample Outdated
@@ -2,3 +2,4 @@ QIITA_DOMAIN='qiita.com'
QIITA_TOKEN='<Qiita トークン>'
QIITA_CLI_ITEMS_ROOT="./tmp"
XDG_CONFIG_HOME="./tmp"
XDG_CACHE_HOME="./tmp/.cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ココだけ

Suggested change
XDG_CACHE_HOME="./tmp/.cache
XDG_CACHE_HOME="./tmp/.cache"

Copy link
Member Author

@ohakutsu ohakutsu Jul 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

うおー、ありがとうございます！
修正します！

@ohakutsu ohakutsu force-pushed the add-package-update-notice branch from ff38106 to 0d3b49e Compare July 18, 2023 07:41
@ohakutsu ohakutsu requested a review from acronhub July 18, 2023 10:03
acronhub
acronhub approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@acronhub acronhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ohakutsu ohakutsu merged commit 1c31df6 into main Jul 19, 2023
@ohakutsu ohakutsu deleted the add-package-update-notice branch July 19, 2023 01:37
@ohakutsu ohakutsu mentioned this pull request Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acronhub acronhub acronhub approved these changes

Assignees

@ohakutsu ohakutsu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohakutsu @acronhub