Skip to content

Support slide mode #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Support slide mode #27

merged 1 commit into from
Jul 19, 2023

Conversation

ohakutsu
Copy link
Member

@ohakutsu ohakutsu commented Jul 13, 2023

What

スライドモードのプレビューができるようにする

How

  • 記事ファイルにslideパラメータが設定されるように変更
    • pullコマンドを実行でslideパラメータを反映できる
  • Qiita Previewでスライドモードのプレビューができるように変更

Breaking Changes

  • 記事ファイルにslideパラメータが必須となる
    • 設定されていない場合、publishコマンド、Qiita Previewでのプレビュー時にエラーになる

Why

Refs

@ohakutsu ohakutsu self-assigned this Jul 13, 2023
@ohakutsu
Copy link
Member Author

Screenshots

image

slideパラメータが存在しないとき

image

@ohakutsu ohakutsu requested a review from getty104 July 14, 2023 11:11
Copy link
Member

@getty104 getty104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.mdにスライドモードはまだ未実装の旨が記載されたままなので、削除をお願いします 🙏

@ohakutsu ohakutsu requested a review from getty104 July 18, 2023 10:44
@ohakutsu ohakutsu force-pushed the add-slide-mode branch 2 times, most recently from a33724f to 09951d0 Compare July 18, 2023 11:02
@ohakutsu ohakutsu requested review from getty104 and removed request for getty104 July 18, 2023 11:04
@ohakutsu
Copy link
Member Author

@getty104 コンフリクトを解消しました!

Copy link
Member

@getty104 getty104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ohakutsu ohakutsu merged commit d8db9a0 into main Jul 19, 2023
@ohakutsu ohakutsu deleted the add-slide-mode branch July 19, 2023 03:17
@ohakutsu ohakutsu mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants