Skip to content

Refactor items show page #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Refactor items show page #26

merged 2 commits into from
Jul 12, 2023

Conversation

ohakutsu
Copy link
Member

What

Qiita Previewの/items/:idページ、/api/items/:idのリファクタリングをした。
また、ESLintを一時的に無効にしているsrc/server/api/items.tsを修正し、ESLintを有効にした。

How

  • Viewモデルを定義
  • src/server/api/items.tsのunused variablesを修正した

Why

Refs

@ohakutsu ohakutsu self-assigned this Jul 12, 2023
@ohakutsu ohakutsu requested a review from getty104 July 12, 2023 03:09
Copy link
Member

@getty104 getty104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ohakutsu ohakutsu merged commit 67e181e into main Jul 12, 2023
@ohakutsu ohakutsu deleted the refactor-items-show-page branch July 12, 2023 05:14
@ohakutsu ohakutsu mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants