Skip to content

Add eslint #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2023
Merged

Add eslint #25

merged 2 commits into from
Jul 12, 2023

Conversation

ohakutsu
Copy link
Member

@ohakutsu ohakutsu commented Jul 11, 2023 •
edited
Loading

What

ESLintを追加する

How

  • ESLintを追加
    • eslint:recommended, @typescript-eslint/recommendedに加え、Reactのルール（react, react-hooks）も設定している
  • 現在lintエラーになるものは一時的に無効になるように.eslintrc.jsに設定している

Why

Refs

@ohakutsu ohakutsu self-assigned this Jul 11, 2023
@ohakutsu ohakutsu requested a review from acronhub July 11, 2023 11:08
acronhub
acronhub approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@acronhub acronhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ありがとうございます。

@ohakutsu ohakutsu merged commit 1d9f7ab into main Jul 12, 2023
@ohakutsu ohakutsu deleted the add-eslint branch July 12, 2023 01:28
@ohakutsu ohakutsu mentioned this pull request Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acronhub acronhub acronhub approved these changes

Assignees

@ohakutsu ohakutsu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohakutsu @acronhub