Skip to content

Drop support for Node.js v18 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Drop support for Node.js v18 #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ jobs:
strategy:
matrix:
node:
- "18.18.0"
- "18.20.4"
- "20.0.0"
- "20.16.0"
- "22.14.0"
needs:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Qiita CLIを使って記事が書けたら、ぜひQiitaに投稿してみてく

### 1. 事前準備

Qiita CLI を使うには `Node.js 18.18.0` 以上が必要です。
Qiita CLI を使うには `Node.js 20.0.0` 以上が必要です。
Node.js をはじめて使う場合はインストールする必要があります。

### 2. Qiita CLI をインストールする
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
},
"packageManager": "yarn@1.22.19",
"engines": {
"node": ">=18.18.0"
"node": ">=20.0.0"
Comment on lines 87 to +88
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding a more specific version range, such as ^20.0.0 instead of >=20.0.0. This indicates that the project is tested and compatible with any version 20.x.x, but might not be compatible with version 21 and above. This can help prevent unexpected issues when newer Node.js versions are released.

If the project is indeed compatible with newer versions, then the current implementation is fine.

"node": "^20.0.0"

},
"lint-staged": {
"*.{js,ts,tsx}": [
Expand Down