Skip to content

GithubActionsからバージョンタグを自動で追加するように修正 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

acronhub
Copy link
Contributor

What

  • NPMパッケージをリリースするGithubActionsで自動的にバージョンタグを追加するようにした

How

Why

Refs

@acronhub acronhub requested a review from ohakutsu July 10, 2023 06:23
git config --global user.name 'github-actions[bot]'
git config --global user.email '41898282+github-actions[bot]@users.noreply.github.com'
git tag -a v${{ env.RELEASED_PACKAGE_VERSION }} -m 'Version ${{ env.RELEASED_PACKAGE_VERSION }}'
git tag v0 v${{ env.RELEASED_PACKAGE_VERSION }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-fオプションが必要な気がします!

Suggested change
git tag v0 v${{ env.RELEASED_PACKAGE_VERSION }}
git tag -f v0 v${{ env.RELEASED_PACKAGE_VERSION }}

[ref]

@acronhub acronhub force-pushed the fix-add-git-tags-in-github-actions branch from c4d61c6 to bf579f8 Compare July 11, 2023 04:47
@acronhub acronhub requested a review from ohakutsu July 11, 2023 04:50
Copy link
Member

@ohakutsu ohakutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acronhub acronhub merged commit 4bfca29 into main Jul 11, 2023
@acronhub acronhub deleted the fix-add-git-tags-in-github-actions branch July 11, 2023 06:07
@ohakutsu ohakutsu mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants