Skip to content

Bump @emotion/react from 11.11.4 to 11.13.0 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 29, 2024

Bumps @emotion/react from 11.11.4 to 11.13.0.

Release notes

Sourced from @​emotion/react's releases.

@​emotion/react@​11.13.0

Minor Changes

  • #3198 d8ff8a5 Thanks @​Andarist! - Migrated away from relying on process.env.NODE_ENV checks to differentiate between production and development builds.

    Development builds (and other environment-specific builds) can be used by using proper conditions (see here). Most modern bundlers/frameworks already preconfigure those for the user so no action has to be taken.

    Default files should continue to work in all environments.

  • #3215 a9f6912 Thanks @​Andarist! - Added edge-light and workerd conditions to package.json manifest to better serve users using Vercel Edge and Cloudflare Workers.

Patch Changes

  • Updated dependencies [d8ff8a5, a9f6912]:
    • @​emotion/cache@​11.13.0
    • @​emotion/serialize@​1.3.0
    • @​emotion/use-insertion-effect-with-fallbacks@​1.1.0
    • @​emotion/utils@​1.4.0

@​emotion/react@​11.12.0

Minor Changes

  • #2815 65a1eea Thanks @​srmagura! - Automatic labeling at runtime is now an opt-in feature. Define globalThis.EMOTION_RUNTIME_AUTO_LABEL = true before Emotion gets initialized to enable it.

Patch Changes

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@emotion/react](https://github.com/emotion-js/emotion) from 11.11.4 to 11.13.0.
- [Release notes](https://github.com/emotion-js/emotion/releases)
- [Changelog](https://github.com/emotion-js/emotion/blob/main/CHANGELOG.md)
- [Commits](https://github.com/emotion-js/emotion/compare/@emotion/react@11.11.4...@emotion/react@11.13.0)

---
updated-dependencies:
- dependency-name: "@emotion/react"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 29, 2024
@dependabot dependabot bot requested review from a team and getty104 and removed request for a team July 29, 2024 05:17
@kimkim0814 kimkim0814 requested review from kimkim0814 and removed request for getty104 August 1, 2024 03:08
@kimkim0814
Copy link
Member

emotion とは

Emotion is a performant and flexible CSS-in-JS library.
ref: https://github.com/emotion-js/emotion

Emotion は、パフォーマンスが高く柔軟性のある CSS-in-JS ライブラリのこと。
JavaScript 内で直接 CSS を記述することができるようになる。

@emotion/react とは

Reactアプリケーションでスタイルを管理するライブラリのこと。

@kimkim0814
Copy link
Member

kimkim0814 commented Aug 1, 2024

11.11.4 から 11.13.0 に伴う変更

マイナーチェンジのみ。

Automatic labeling at runtime is now an opt-in feature. Define globalThis.EMOTION_RUNTIME_AUTO_LABEL = true before Emotion gets initialized to enable it.

ランタイムでの自動ラベリングがオプトイン機能になった。

trueの場合はcss-xxx-SidebarArticles、falseの場合はcss-xxxのような表記となる。

動作確認

Articleコンポーネントでで CSS-inJSが使用されているため確認したが
問題なく描画されていた。

しかし、自動ラベリングがオプトイン機能となったためクラス名にコンポーネント名が
つかない形になっていた。

TODO

開発にあたって、生成されたDOMからコンポーネント名をgrepする場合もあるので
EMOTION_RUNTIME_AUTO_LABELをtrueにして前回までと同様の挙動にする。

@kimkim0814
Copy link
Member

kimkim0814 commented Aug 1, 2024

EMOTION_RUNTIME_AUTO_LABEL = trueをどこに定義すれば良いか

rootコンポーネント(App)をrenderしている、
src/client/index.tsx で良いと考えている。

@kimkim0814 kimkim0814 self-assigned this Aug 1, 2024
@kimkim0814 kimkim0814 requested a review from ohakutsu August 1, 2024 06:18
global.d.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ルートではなく/src/types/配下に配置するのはどうでしょうか?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ohakutsu

ルートではなく/src/types/配下に配置するのはどうでしょうか?

ありですね。
変更して、動作の方問題なければリレビューに出します!

@kimkim0814 kimkim0814 force-pushed the dependabot/npm_and_yarn/emotion/react-11.13.0 branch 2 times, most recently from 8a85fb9 to 15ba145 Compare August 2, 2024 09:15
@kimkim0814 kimkim0814 requested a review from ohakutsu August 2, 2024 09:15
@kimkim0814 kimkim0814 merged commit a7fbf5b into main Aug 13, 2024
6 checks passed
@kimkim0814 kimkim0814 deleted the dependabot/npm_and_yarn/emotion/react-11.13.0 branch August 13, 2024 06:21
@ohakutsu ohakutsu mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants