Add error status #16
Merged
Add error status #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getty104
requested review from
a team and
acronhub
and removed request for
a team
acronhub
reviewed
Jul 5, 2023
src/commands/publish.ts
Outdated
| @@ -45,7 +46,12 @@ export const publish = async (argv: string[]) => { | |||
| // Validate | |||
| const invalidItemMessages = targetItems.reduce((acc, item) => { | |||
| const errors = validateItem(item); | |||
There was a problem hiding this comment.
📝 動作確認
こんな感じのデータ。タグを未記入にする
---
title: newArticle001
tags:
private: true
updated_at: '2023-07-05T15:17:19+09:00'
id: aae380a27065a68d52d9
organization_url_name: null
---
validateItem(item) 内で0 < tags.length && tags.length <= 5の部分でエラーでました
TypeError: Cannot read properties of null (reading 'length')
at Object.isValid (/Users/h-3109/Documents/workspace/pj-qiita/qiita-cli/dist/lib/validators/item-validator.js:40:25)
at /Users/h-3109/Documents/workspace/pj-qiita/qiita-cli/dist/lib/validators/item-validator.js:53:24QiitaPreviewだと、item-validator.jsの前にエラーにして処理がいかないようにしています。
getty104
force-pushed
the
add-error-status
branch
from
517826b to
dc0238d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
increments/qiita-discussions#496 への対応を行う
How
Why
Refs