API リクエスト時に UserAgent を設定した #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atm-snag2
requested review from
a team,
kyntk and
ohakutsu
and removed request for
a team
kyntk
reviewed
Jul 5, 2023
src/lib/get-qiita-api-instance.ts
Outdated
Comment on lines
18
to
21
| const { token } = options || { token: undefined }; | ||
| const { accessToken } = | ||
| token === undefined ? await config.getCredential() : { accessToken: token }; | ||
| return accessToken; |
There was a problem hiding this comment.
短く書けそうです
Suggested change
| const { token } = options || { token: undefined }; | |
| const { accessToken } = | |
| token === undefined ? await config.getCredential() : { accessToken: token }; | |
| return accessToken; | |
| return options?.token ?? (await config.getCredential()).accessToken; |
atm-snag2
force-pushed
the
change-user-agent
branch
from
4e29f7e to
6a059de
Compare
ohakutsu
approved these changes
Jul 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Why
Refs