Replacing Thread with Task in FileSaver
#143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for this! I'd need to do some testing on this. Have you tried running the existing Unit Tests with the Unity Test Runner to see if they pass? Can you think of any other tests to ensure this functionality is working as expected? |
|
The test runner passes all the tests. I'll also go over the tests and see what I can add to it. |
|
I take back what I had said earlier, while there are gains in some place, it seems to be clogging the GC (I think). I'll try out a few other things and see how it pans out. Put in another PR if that works out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of
ThreadwithTaskinFileSaver. I had had a large number of trackers (>50) in one of my scenes and the I/O was a performance bottleneck, which is a big problem for me as it impacts my time calculations. Using tasks allows to use more threads and also is a cleaner interface (and also recommended).