Skip to content

Check for selection and insert character over selection. #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

Check for selection and insert character over selection. #38

merged 1 commit into from
Jul 16, 2019

Conversation

aldinezi
Copy link
Contributor

@aldinezi aldinezi commented Jul 16, 2019 •
edited
Loading

This expands inserting behavior, to simulate hardware keyboard when inserting on selected range.

Fixes #39

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 5.042% when pulling 7132f6a on aldinezi:expand_insert into fdde574 on icebob:master.

@aldinezi aldinezi mentioned this pull request Jul 16, 2019
Closed
@prskaloz
Copy link

When can we expect this to be merged and released? I'm having same issue as aldinezi..

@aldinezi
Copy link
Contributor Author

@prskaloz No pressure. I have no estimates, let's see what code owner thinks. Hopefully, soon. :)

icebob
icebob approved these changes Jul 16, 2019
View reviewed changes
Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@icebob icebob merged commit 4bf5900 into icebob:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inserting over selection
4 participants
@aldinezi @coveralls @prskaloz @icebob