Correct key widths #34
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently issue: When giving keys a custom size it can be hard to make them align correctly with the other lines, and the math doesn't add up. For instance, in the page running in
npm run dev
, the0
key for the numeric input is supposed to be 3x as big as a normal key. A normal keyflex: 40
, so logically, the0
key should be{ size: 40 * 3 }
, but then it is too small so it is set to130
. This is caused by themargin
s mixed with flex.This PR fixes this so that the keys align correctly, and the math adds up. It is mostly just code around, and had to wrap all keys in another
div
.I tried to keep the diff clean, but I had to indent so I suggest you look at the diff with "No Whitespace" enabled.