Skip to content

lowercase all http header and rpc metadata keys #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2021
Merged

lowercase all http header and rpc metadata keys #250

merged 1 commit into from
Feb 3, 2021

Conversation

davexroth
Copy link
Contributor

@davexroth davexroth commented Feb 2, 2021 •
edited
Loading

For consistent lookup of http headers and rpc metadata in the span attribute map, we should always lower case them.

This allows collector processors to lookup headers without having to pre-process the span.

@davexroth davexroth requested a review from pavolloffay February 2, 2021 19:29
pavolloffay
pavolloffay approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please describe the use-case in the PR description?

@davexroth davexroth merged commit da81a5d into main Feb 3, 2021
@davexroth davexroth deleted the lowercase_header_keys branch February 3, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davexroth @pavolloffay