Skip to content

Fix StableDiffusionPipeline when text_encoder=None #8297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented May 28, 2024

What does this PR do?

FIx for SD Pipeline when text_encoder=None and tokenizer=None

Fixes # (issue)
#8287

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested review from sayakpaul and yiyixuxu May 28, 2024 07:16
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

We should consider adding tests for this. I think this is a real scenario.

@sayakpaul
Copy link
Member

Cc: @bghira could you test if this solves the issue you reported?

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@DN6
Copy link
Collaborator Author

DN6 commented May 29, 2024

We should consider adding tests for this. I think this is a real scenario.
@sayakpaul a fast test has been included in the PR.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yiyixuxu yiyixuxu merged commit 42cae93 into main May 29, 2024
17 checks passed
@yiyixuxu yiyixuxu deleted the sd-prompt-fix branch May 29, 2024 19:00
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* update

* update

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants