Make InstructPix2Pix Training Script torch.compile compatible #6558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charchit7
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
Jan 13, 2024
| @@ -965,14 +971,14 @@ def collate_fn(examples): | |||
| # Create the pipeline using the trained modules and save it. | |||
| accelerator.wait_for_everyone() | |||
| if accelerator.is_main_process: | |||
| unet = accelerator.unwrap_model(unet) | |||
| unet = unet | |||
There was a problem hiding this comment.
What's this? :D
Why can't we do unet = unwrap_model(unet)?
sayakpaul
reviewed
Jan 13, 2024
Comment on lines
-974
to
-975
| text_encoder=accelerator.unwrap_model(text_encoder), | ||
| vae=accelerator.unwrap_model(vae), |
There was a problem hiding this comment.
I was testing output forgot the change. :D
sayakpaul
reviewed
Jan 13, 2024
Thank you, fixed. |
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…gface#6558) * added torch.compile for pix2pix * required changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #6503 for
instruct pix2pixBefore submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul 🔢