Make text-to-image SD LoRA Training Script torch.compile compatible #6555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghira
reviewed
Jan 13, 2024
| @@ -746,7 +752,7 @@ def collate_fn(examples): | |||
| raise ValueError(f"Unknown prediction type {noise_scheduler.config.prediction_type}") | |||
|
|
|||
| # Predict the noise residual and compute loss | |||
| model_pred = unet(noisy_latents, timesteps, encoder_hidden_states).sample | |||
| model_pred = unet(noisy_latents, timesteps, encoder_hidden_states, return_dict=False)[0] | |||
There was a problem hiding this comment.
torch.compile() will throw an error about TensorVariables otherwise.
There was a problem hiding this comment.
it doesn't here. i just implemented this in ST the other day... didn't change return_dict at all.
bghira
pushed a commit
to bghira/SimpleTuner
that referenced
this pull request
Jan 13, 2024
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…uggingface#6555) make compile compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Partially fixes #6503
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.