[Training] make checkpointing compatible when using torch.compile (part II)
#6511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
sayakpaul
changed the title
torch.compile.torch.compile (part II)
sayakpaul
commented
Jan 10, 2024
| @@ -1621,16 +1627,16 @@ def compute_text_embeddings(prompt, text_encoders, tokenizers): | |||
| # Save the lora layers | |||
| accelerator.wait_for_everyone() | |||
| if accelerator.is_main_process: | |||
| unet = accelerator.unwrap_model(unet) | |||
| unet = unwrap_model(unet) | |||
There was a problem hiding this comment.
For intermediate places (such as performing validation inference) where we do use accelerator.unwrap_model() -- it's not an issue as the models are directly used. But here, since we're obtaining the state dicts, we need to get the _orig_mod out in case torch.compile() was called. LMK if it's not clear.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
6 tasks
6 tasks
6 tasks
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…part II) (huggingface#6511) make checkpointing compatible when using torch.compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up of: #6483