[UniDiffuser Tests] Fix some tests #3609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W.r.t the UniDiffusers failing here.
This PR fixes some UniDiffuser tests.
I first reproduced the environment in which our test suite is run following https://github.com/huggingface/diffusers/blob/main/.github/workflows/push_tests.yml. It's as simple as:
diffusers/diffusers-pytorch-cuda
).diffusers
from the PR branch.Then I ran:
On an A100, with the changes introduced in this PR all the tests from
test_unidiffuser.py
passed including the SLOW ones.But on a V100, it failed with:
@patrickvonplaten any thoughts on how this should be handled? Since our SLOW tests are run on a V100 always, I think it's okay to switch "'a living room'" to ensure the test passes but on an A100 this would fail complaining:
(Just the opposite of the failure noted earlier)
Cc: @dg845