-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix panorama to support all schedulers #3546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Super nice PR! Good job @Isotr0py . @sayakpaul I'll let you review this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is an elegant solution to deal with stateful schedulers like PNDM!
Can we also fix this test case then?
def test_stable_diffusion_panorama_pndm(self): |
Also Cc: @omerbt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
* refactor blocks init * refactor blocks loop * remove unused function and warnings * fix scheduler update location * reformat code * reformat code again * fix PNDM test case * reformat pndm test case
* refactor blocks init * refactor blocks loop * remove unused function and warnings * fix scheduler update location * reformat code * reformat code again * fix PNDM test case * reformat pndm test case
PNDMScheduler
for panorama pipeline.Similar to #3499, make all schedulers sync with blocks sampling. This can solve most of the issues about failed images generation in panorama pipeline.
Test code
Results
PNDMScheduler
UniPCMultistepScheduler
KDPM2DiscreteScheduler
DEISMultistepScheduler