Skip to content

add intermediate logging for dreambooth training script #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

yiyixuxu
Copy link
Collaborator

@yiyixuxu yiyixuxu commented Mar 5, 2023

tested logging with wandb in this run https://wandb.ai/yiyixu/dreambooth/runs/f89j7zmo?workspace=user-yiyixu

based on #2178 (review)
should fix #1714

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 5, 2023

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten
Copy link
Contributor

Cool - good job :-)

cc @williamberman can you check here?

@patrickvonplaten
Copy link
Contributor

Also should we maybe adapt the test to make sure this feature is tested?
E.g. I think we can adapt the test here:

def test_dreambooth(self):

cc @williamberman maybe you have some clearer pointers as you wrote the script :-)

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patrickvonplaten
Copy link
Contributor

Just for the future re: #2557 (comment), it's usually nice to either:

  • reply why no test is necessary IUO
  • Or add a test
  • Or wait with merge until @williamberman has left some feedback

But ok for now, think it's ok to not have it tested (would have been nice though)

@kashif kashif deleted the dreambooth-logging branch March 19, 2023 12:21
mengfei25 pushed a commit to mengfei25/diffusers that referenced this pull request Mar 27, 2023
…2557)

* add  intermediate logging
---------

Co-authored-by: yiyixuxu <yixu310@gmail,com>
w4ffl35 pushed a commit to w4ffl35/diffusers that referenced this pull request Apr 14, 2023
…2557)

* add  intermediate logging
---------

Co-authored-by: yiyixuxu <yixu310@gmail,com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…2557)

* add  intermediate logging
---------

Co-authored-by: yiyixuxu <yixu310@gmail,com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants