-
Notifications
You must be signed in to change notification settings - Fork 6k
add intermediate logging for dreambooth training script #2557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Cool - good job :-) cc @williamberman can you check here? |
Also should we maybe adapt the test to make sure this feature is tested? diffusers/examples/test_examples.py Line 122 in 1598a57
cc @williamberman maybe you have some clearer pointers as you wrote the script :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Just for the future re: #2557 (comment), it's usually nice to either:
But ok for now, think it's ok to not have it tested (would have been nice though) |
…2557) * add intermediate logging --------- Co-authored-by: yiyixuxu <yixu310@gmail,com>
…2557) * add intermediate logging --------- Co-authored-by: yiyixuxu <yixu310@gmail,com>
…2557) * add intermediate logging --------- Co-authored-by: yiyixuxu <yixu310@gmail,com>
tested logging with wandb in this run https://wandb.ai/yiyixu/dreambooth/runs/f89j7zmo?workspace=user-yiyixu
based on #2178 (review)
should fix #1714