Skip to content

Fix ONNX checkpoint loading #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Fix ONNX checkpoint loading #2544

merged 4 commits into from
Mar 3, 2023

Conversation

anton-l
Copy link
Member

@anton-l anton-l commented Mar 3, 2023

ONNX_WEIGHTS_NAME and ONNX_EXTERNAL_WEIGHTS_NAME should go hand in hand when adding file filters, as one is an ONNX model definition (model.onnx) and the other is an external weight binary (weights.pb) that stores 2GB+ checkpoints.

This PR makes sure that weights.pb is not filtetered out when downloading an onnx checkpoint

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 3, 2023

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten
Copy link
Contributor

Thanks!

@anton-l anton-l merged commit 4f0141a into main Mar 3, 2023
@anton-l anton-l deleted the fix-onnx-checkpoints branch March 3, 2023 15:09
mengfei25 pushed a commit to mengfei25/diffusers that referenced this pull request Mar 27, 2023
* Revert "Disable ONNX tests (huggingface#2509)"

This reverts commit a0549fe.

* add external weights

* + pb

* style
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* Revert "Disable ONNX tests (huggingface#2509)"

This reverts commit a0549fe.

* add external weights

* + pb

* style
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* Revert "Disable ONNX tests (huggingface#2509)"

This reverts commit a0549fe.

* add external weights

* + pb

* style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants