-
Notifications
You must be signed in to change notification settings - Fork 6k
[Training] Better image interpolation in training scripts #11206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hlky
reviewed
Apr 4, 2025
linoytsaban
approved these changes
Apr 4, 2025
thank you |
sayakpaul
reviewed
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the comments are resolved.
Co-authored-by: hlky <hlky@hlky.ac>
sayakpaul
reviewed
Apr 8, 2025
Failing test is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed here, this PR will add LANCZOS as a default interpolation mode for the image resizing in the training scripts and if the users prefers can choose BILINEAR.
I'll add this to the most popular recent ones and leave the rest to the community if they want to add them to other training scripts.
I'll do some training runs first to test if I can see the difference, but still, I already know that LANCZOS is better and that the models can pick subtle details that the human eye can't.
Fixes #6397
Who can review?
@bghira @linoytsaban @sayakpaul
Additional
Here's a little script if you want to test and try to see the difference: