Skip to content

Add code coverage reports #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2016
Merged

Add code coverage reports #220

merged 2 commits into from
Apr 25, 2016

Conversation

gsnedders
Copy link
Member

No description provided.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 85de9fd on gsnedders:codecov into 46dae3d on html5lib:master.

@gsnedders
Copy link
Member Author

Build failure is because coverage >= 4.0.0 doesn't support 3.2

@gsnedders
Copy link
Member Author

@gsnedders
Copy link
Member Author

For the curious wondering why we're going with the more obscure codecov instead of coveralls: codecov have branch coverage.

@gsnedders gsnedders closed this Dec 16, 2015
@gsnedders gsnedders reopened this Dec 16, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/6052

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.33% when pulling eb56e79 on gsnedders:codecov into 46dae3d on html5lib:master.

@gsnedders
Copy link
Member Author

PyPy with coverage seems really slow for some reason; should probably move to only having coverage with CPython.

@gsnedders
Copy link
Member Author

And PyPy3k fails big-time with stuff like:

html5lib/tests/tree_construction.py:65: in runtest
    output = convertTreeDump(p.tree.testSerializer(document))
html5lib/treebuilders/etree.py:319: in testSerializer
    return testSerializer(element)
E   TypeError: testSerializer() takes exactly 2 arguments (1 given)

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.33% when pulling c3ca303 on gsnedders:codecov into 46dae3d on html5lib:master.

@gsnedders
Copy link
Member Author

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 969d29b on gsnedders:codecov into 4205423 on html5lib:master.

@gsnedders
Copy link
Member Author

@jgraham r?

@codecov-io
Copy link

Current coverage is 89.41%

Branch #220 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.
Review entire Coverage Diff as of 8352c62

Powered by Codecov. Updated on successful CI builds.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling c7fbb91 on gsnedders:codecov into d999875 on html5lib:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 9e27ea1 on gsnedders:codecov into d999875 on html5lib:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling fc0077a on gsnedders:codecov into d999875 on html5lib:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling a231231 on gsnedders:codecov into d999875 on html5lib:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 66a3f42 on gsnedders:codecov into 91876a7 on html5lib:master.

@gsnedders gsnedders merged commit a3bb980 into html5lib:master Apr 25, 2016
@gsnedders gsnedders deleted the codecov branch April 25, 2016 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants