-
Notifications
You must be signed in to change notification settings - Fork 96
single executable jbang-based junit test class #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
61ae4c1
to
b2719bd
Compare
Thanks @blafond! It needs some minor improvements to the way it's documented but overall it looks good to me. I've created a quick POC here: https://github.com/DavideD/hibernate-reactive/blob/721-jbang-executable-test/tooling/jbang/Example.java If you want to see them in action, here's how it works:
Not sure which one I prefer. Maybe we can keep both? The JUnit one could be helpful to show how one can test Hibernate Reactive (maybe we can make it make it slightly more complex and add a couple of tests instead of only keep one) while the example one might be more familiar to the user and we can keep it simpler. Note that I've asked @blafond to not create a template for now (because it makes it slightly harder to prototype with them). I think it makes sense to convert these classes to JBang templates ones we are happy with them and we can send a pr to JBang to add them to the catalogue. @gavinking What do you think? Cheers |
b2719bd
to
ac958c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
looks pretty good.
We can play a bit more with this in the future, but I think this is a good starting point.
I will probably change a couple of minor things when working on the contribution guide.
In particular, I wouldn't keep a separate README for this. But we can change it later.
targets issue #721
FIrst pass at a single junit test class that's executable by jbang CLI