-
Notifications
You must be signed in to change notification settings - Fork 96
improve wording of callout #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
* Replace deprecated method calls * Remove some Idea warnings * Replace with method reference * Change to static class a test entity
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
They made it reactive with the upgrade to Vert.x SQL client 4. We also have to update the tests becaus now they have to wait for the session to be close before moving to the next chained operation.
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
Now that the close method is reactive, we cannot make the session Autoclosable anymore.
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
* Replace deprecated method calls * Remove some Idea warnings * Replace with method reference * Change to static class a test entity
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
They made it reactive with the upgrade to Vert.x SQL client 4. We also have to update the tests becaus now they have to wait for the session to be close before moving to the next chained operation.
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
Now that the close method is reactive, we cannot make the session Autoclosable anymore.
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
They made it reactive with the upgrade to Vert.x SQL client 4. We also have to update the tests becaus now they have to wait for the session to be close before moving to the next chained operation.
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 26, 2021
Now that the close method is reactive, we cannot make the session Autoclosable anymore.
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 29, 2021
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 29, 2021
* Replace deprecated method calls * Remove some Idea warnings * Replace with method reference * Change to static class a test entity
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 29, 2021
They made it reactive with the upgrade to Vert.x SQL client 4. We also have to update the tests becaus now they have to wait for the session to be close before moving to the next chained operation.
DavideD
added a commit
to DavideD/hibernate-reactive
that referenced
this pull request
Apr 29, 2021
Now that the close method is reactive, we cannot make the session Autoclosable anymore.
DavideD
added a commit
that referenced
this pull request
Apr 29, 2021
DavideD
added a commit
that referenced
this pull request
Apr 29, 2021
* Replace deprecated method calls * Remove some Idea warnings * Replace with method reference * Change to static class a test entity
DavideD
added a commit
that referenced
this pull request
Apr 29, 2021
They made it reactive with the upgrade to Vert.x SQL client 4. We also have to update the tests becaus now they have to wait for the session to be close before moving to the next chained operation.
DavideD
added a commit
that referenced
this pull request
Apr 29, 2021
Now that the close method is reactive, we cannot make the session Autoclosable anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DavideD does this help?