Fix for deprecations #1769
Closed
Fix for deprecations #1769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+61
to
+62
| metadata.getTypeConfiguration() | ||
| .getMetadataBuildingContext() |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
...core/src/main/java/org/hibernate/reactive/engine/impl/ReactiveEntityRegularInsertAction.java
Fixed
Show fixed
Hide fixed
...active-core/src/main/java/org/hibernate/reactive/engine/impl/ReactiveEntityUpdateAction.java
Fixed
Show resolved
Hide resolved
...active-core/src/main/java/org/hibernate/reactive/engine/impl/ReactiveEntityUpdateAction.java
Fixed
Show resolved
Hide resolved
...active-core/src/main/java/org/hibernate/reactive/engine/impl/ReactiveEntityUpdateAction.java
Fixed
Show resolved
Hide resolved
blafond
force-pushed
the
issue_1714_deprecations
branch
2 times, most recently
from
8a35629 to
4bfd62c
Compare
DavideD
reviewed
Sep 22, 2023
There was a problem hiding this comment.
Thanks,
we usually use a commit message like "fix deprecations" for simple intuitive things.
But here there are a lot more changes that don't seem intuitive or natural to me.
Please, make sure to update the commit histories or clarifying what's going on in the commit message.
hibernate-reactive-core/src/main/java/org/hibernate/reactive/engine/impl/Cascade.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/hibernate/reactive/engine/impl/ReactiveEntityRegularInsertAction.java
Outdated
Show resolved
Hide resolved
...active-core/src/main/java/org/hibernate/reactive/engine/impl/ReactiveEntityUpdateAction.java
Outdated
Show resolved
Hide resolved
DavideD
reviewed
Sep 22, 2023
...ate-reactive-core/src/main/java/org/hibernate/reactive/session/impl/ReactiveSessionImpl.java
Outdated
Show resolved
Hide resolved
DavideD
reviewed
Sep 22, 2023
hibernate-reactive-core/src/test/java/org/hibernate/reactive/HQLQueryParameterNamedTest.java
Outdated
Show resolved
Hide resolved
blafond
force-pushed
the
issue_1714_deprecations
branch
from
4bfd62c to
20a71b5
Compare
...active-core/src/main/java/org/hibernate/reactive/engine/impl/ReactiveEntityUpdateAction.java
Show resolved
Hide resolved
blafond
force-pushed
the
issue_1714_deprecations
branch
from
20a71b5 to
3d9e590
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1714
Not all of the deprecations are fixed, but a good start.