Revert "RowId ignored during deletes" #1763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+69
to
+74
| operationGroup.forEachOperation( (position, mutation) -> { | ||
| if ( mutation != null ) { | ||
| final String tableName = mutation.getTableDetails().getTableName(); | ||
| mutationExecutor.getPreparedStatementDetails( tableName ); | ||
| } | ||
| } | ||
| } ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+107
to
+119
| operationGroup.forEachOperation( (position, jdbcMutation) -> { | ||
| final EntityTableMapping tableDetails = (EntityTableMapping) jdbcMutation.getTableDetails(); | ||
| breakDownKeyJdbcValues( id, rowId, session, jdbcValueBindings, tableDetails ); | ||
| breakDownIdJdbcValues( id, rowId, session, jdbcValueBindings, rowIdMapping, tableDetails ); | ||
| final PreparedStatementDetails statementDetails = mutationExecutor.getPreparedStatementDetails( tableDetails.getTableName() ); | ||
| if ( statementDetails != null ) { | ||
| PreparedStatementAdaptor.bind( statement -> { | ||
| PrepareStatementDetailsAdaptor detailsAdaptor = new PrepareStatementDetailsAdaptor( | ||
| statementDetails, | ||
| statement, | ||
| session.getJdbcServices() | ||
| ); | ||
| PrepareStatementDetailsAdaptor detailsAdaptor = new PrepareStatementDetailsAdaptor( statementDetails, statement, session.getJdbcServices() ); | ||
| // force creation of the PreparedStatement | ||
| //noinspection resource | ||
| detailsAdaptor.resolveStatement(); | ||
| } ); | ||
| } | ||
| } | ||
| } ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+131
to
+135
| getStaticDeleteGroup().forEachOperation( (position, mutation) -> { | ||
| if ( mutation != null ) { | ||
| mutationExecutor.getPreparedStatementDetails( mutation.getTableDetails().getTableName() ); | ||
| } | ||
| } | ||
| } ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1762
Sorry, merged by mistake