[#1501] Fix SubselectFetchTest

[blafond]

fixes #1502

• Follows ORM's SubselectFetchTest.testSubselectFetchHql(...)
• initialization on a collection is forced via a call to a collections size()

[blafond]

ReactiveEntityResultInitializer was extending ReactiveAbstractEntityInitializer but ReactiveAbstractEntityInitializer was not extending EntityResultInitializer (was extending AbstractEntityInitiailzer)

Replaced the extended class of ReactiveAbstractEntityInitializer with EntityResultInitializer so the proper methods were called during the loading of associated collection

[blafond]

Note that this change/fix did not fix #1501. BatchFetchTest testQuery() and testBatchLoad() are failing

[DavideD]

I don't understand why this fixes the issue, and I don't think it's correct even if it does.
That's said, I think you are on the right track.

The reason I don't think this is correct is that now ReactiveEntityJoinedFetchInitializer becomes a subclass of EntityResultInitializer. This is different from what's happening in ORM where EntityResultInitializer and EntityJoinedFetchInitializer are both subclasses of AbstractEntityInitializer. That's why in Hibernate Reactive we have ReactiveAbstractEntityInitializer mimicking AbstractEntityInitializer

Also, I don't understand why this change makes the test pass.
The only difference between ReactiveEntityResultInitializer and EntityResultInitializer is the CONCRETE_NAME. Maybe that's what's causing the test to fail?

[blafond]

ORM's 6.2 version of SubselectFetch contains a check on EntityResultInitializer which explains why my fix works.

In ORM 6.3, they've cleaned up SubselectFetch and that check is gone.

So I can merge my commit if we need to release another HR version off of 6.2, or push this issue to our 6.3 version?

[DavideD]

We cannot merge this commit.

We could avoid extending ReactiveAbstractEntityInitializer and convert it to a delegator similar to what we do in ReactiveSingleTableEntityPersister

[blafond]

k... I'll check that out. thx

[DavideD]

Note that this issue was solved by a change in Hibernate ORM.
From this PR we only need the commit that re-enable the test after the next Hibernate ORM upgrade.

[DavideD]

@blafond I've just tested this with 6.3 and it doesn't seem to work. Could you double check?
I've updated the 2.1 branch to include 6.3.0.Final already

[blafond]

sure

[DavideD]

Superseded by #1746