Add integration test #1689
Closed
Add integration test #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideD
force-pushed
the
1686-integration-tests
branch
2 times, most recently
from
0406f45 to
252755c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...s/verticle-postgres-it/src/main/java/org/hibernate/reactive/it/verticle/ProductVerticle.java
Fixed
Show fixed
Hide fixed
| } | ||
|
|
||
| private Future<Product> getProduct(RoutingContext ctx) { | ||
| long id = Long.parseLong( ctx.pathParam( "id" ) ); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
...chempower-postgres-it/src/main/java/org/hibernate/reactive/it/techempower/WorldVerticle.java
Fixed
Show fixed
Hide fixed
...s/verticle-postgres-it/src/main/java/org/hibernate/reactive/it/verticle/ProductVerticle.java
Fixed
Show fixed
Hide fixed
|
|
||
| postRequests.add( send ); | ||
| } | ||
| return all( postRequests ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| .deployVerticle( () -> new ProductVerticle( () -> sf ), deploymentOptions ) | ||
| .map( ignore -> webClient ) | ||
| .compose( this::createProducts ) | ||
| .map( ignore -> webClient ) |
Check notice
Code scanning / CodeQL
Useless parameter
| .compose( this::createProducts ) | ||
| .map( ignore -> webClient ) | ||
| .compose( this::findProducts ) | ||
| .onSuccess( res -> context.completeNow() ) |
Check notice
Code scanning / CodeQL
Useless parameter
...wer-postgres-it/src/test/java/org/hibernate/reactive/techempower/TechEmpowerRestAPITest.java
Fixed
Show fixed
Hide fixed
...wer-postgres-it/src/test/java/org/hibernate/reactive/techempower/TechEmpowerRestAPITest.java
Fixed
Show fixed
Hide fixed
DavideD
force-pushed
the
1686-integration-tests
branch
from
252755c to
18e456f
Compare
| .deployVerticle( () -> new WorldVerticle( () -> sf ), deploymentOptions ) | ||
| .map( ignore -> webClient ) | ||
| .compose( this::createData ) | ||
| .map( ignore -> webClient ) |
Check notice
Code scanning / CodeQL
Useless parameter
| .compose( this::createData ) | ||
| .map( ignore -> webClient ) | ||
| .compose( this::updates ) | ||
| .onSuccess( res -> context.completeNow() ) |
Check notice
Code scanning / CodeQL
Useless parameter
DavideD
force-pushed
the
1686-integration-tests
branch
5 times, most recently
from
9db6a29 to
751ff2a
Compare
Remove warnings and refactor the createion of the test tasks
DavideD
force-pushed
the
1686-integration-tests
branch
from
751ff2a to
3b7fe84
Compare
|
Superseeed by #1690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build should fail because it doesn't include this fix
Fix #1686