Experimental solution for HREACT-34 #1683
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideD
reviewed
Jun 29, 2023
| // stage gets updated by doDynamicUpdate and doStaticUpdate which get called by performUpdate | ||
| return stage != null ? stage : voidFuture(); | ||
| final CompletionStage<Void> finalStage = stage != null ? stage : voidFuture(); | ||
| return finalStage; |
There was a problem hiding this comment.
Is this finalStage necessary, or it's you being overzealous?
|
I'm fine with this solution. I don't think it's too complicated and we can refactor the code later. |
|
We've decided to go with the minimal solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HREACT-34