Skip to content

HHH-17167 Unable to locate parameter for RESTRICT - DELETE error when removing entity with RowId #7306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

mbladel
Copy link
Member

@mbladel mbladel commented Sep 8, 2023

Copy link
Member

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do the changes impact HR? @DavideD

@DavideD
Copy link
Member

DavideD commented Sep 13, 2023

They require some changes in HR because the signature on some methods as change, it should be fine but I haven't try to fix the compilation errors yet.
I will do it today and let you know

@mbladel
Copy link
Member Author

mbladel commented Sep 13, 2023

@DavideD tanks for checking, just for context the signature changes were needed to clear up the default delete behavior when a @RowId is available. Before, the static delete operation built at boot time used the primary key, while whenever a row-id was available we always built a dynamic delete. Since the row-id case is the most common and should be the default, the operations have now been switched, which is also consistent with what we already did for updates.

Copy link
Member

@DavideD DavideD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine with Hibernate Reactive after fixing a few compilation errros.

Thanks for the warning.

@beikov beikov merged commit 0ecd5d8 into hibernate:main Sep 15, 2023
@mbladel mbladel deleted the HHH-17167 branch September 15, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants