Skip to content

Commit 977959d

Browse files
committed
HHH-16900 Avoid using the old method, ensure by removing the deprecated methods
1 parent 6d3ecf8 commit 977959d

File tree

5 files changed

+10
-95
lines changed

5 files changed

+10
-95
lines changed

hibernate-core/src/main/java/org/hibernate/sql/model/MutationOperationGroup.java

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@
66
*/
77
package org.hibernate.sql.model;
88

9-
import java.util.List;
10-
import java.util.function.BiConsumer;
11-
import java.util.function.BiFunction;
12-
139
/**
1410
* Group of {@link MutationOperation} references for a specific
1511
* logical operation (target + type)
@@ -52,27 +48,4 @@ public interface MutationOperationGroup {
5248
*/
5349
MutationOperation getOperation(String tableName);
5450

55-
/**
56-
* @deprecated Will be removed - use a combination of {@link #getNumberOfOperations()} and {@link #getOperation(int)}
57-
* to iterate the list of operations.
58-
*/
59-
@Deprecated(forRemoval = true)
60-
List<MutationOperation> getOperations();
61-
62-
/**
63-
* Visit each operation
64-
* @deprecated Will be removed - use a combination of {@link #getNumberOfOperations()} and {@link #getOperation(int)}
65-
* to iterate the list of operations.
66-
*/
67-
@Deprecated(forRemoval = true)
68-
void forEachOperation(BiConsumer<Integer, MutationOperation> action);
69-
70-
/**
71-
* Test whether any operations match the condition
72-
* @deprecated Will be removed - use a combination of {@link #getNumberOfOperations()} and {@link #getOperation(int)}
73-
* to iterate the list of operations.
74-
*/
75-
@Deprecated(forRemoval = true)
76-
boolean hasMatching(BiFunction<Integer, MutationOperation, Boolean> matcher);
77-
7851
}

hibernate-core/src/main/java/org/hibernate/sql/model/internal/MutationGroupNone.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import java.util.Locale;
1010
import java.util.function.BiConsumer;
1111

12-
import org.hibernate.sql.model.MutationOperation;
1312
import org.hibernate.sql.model.MutationTarget;
1413
import org.hibernate.sql.model.MutationType;
1514
import org.hibernate.sql.model.ast.MutationGroup;
@@ -46,17 +45,17 @@ public int getNumberOfTableMutations() {
4645
}
4746

4847
@Override
49-
public <O extends MutationOperation, M extends TableMutation<O>> M getSingleTableMutation() {
48+
public TableMutation getSingleTableMutation() {
5049
return null;
5150
}
5251

5352
@Override
54-
public <O extends MutationOperation, M extends TableMutation<O>> M getTableMutation(String tableName) {
53+
public TableMutation getTableMutation(String tableName) {
5554
return null;
5655
}
5756

5857
@Override
59-
public <O extends MutationOperation, M extends TableMutation<O>> void forEachTableMutation(BiConsumer<Integer, M> action) {
58+
public void forEachTableMutation(BiConsumer<Integer, TableMutation> action) {
6059
}
6160

6261
@Override

hibernate-core/src/main/java/org/hibernate/sql/model/internal/MutationOperationGroupNone.java

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,6 @@
66
*/
77
package org.hibernate.sql.model.internal;
88

9-
import java.util.Collections;
10-
import java.util.List;
11-
import java.util.function.BiConsumer;
12-
import java.util.function.BiFunction;
13-
149
import org.hibernate.sql.model.MutationOperation;
1510
import org.hibernate.sql.model.MutationTarget;
1611
import org.hibernate.sql.model.MutationType;
@@ -44,23 +39,9 @@ public MutationOperation getOperation(int idx) {
4439
throw new IndexOutOfBoundsException( idx );
4540
}
4641

47-
@Override
48-
public List<MutationOperation> getOperations() {
49-
return Collections.emptyList();
50-
}
51-
5242
@Override
5343
public MutationOperation getOperation(String tableName) {
5444
return null;
5545
}
5646

57-
@Override
58-
public void forEachOperation(BiConsumer<Integer, MutationOperation> action) {
59-
}
60-
61-
@Override
62-
public boolean hasMatching(BiFunction<Integer, MutationOperation, Boolean> matcher) {
63-
return false;
64-
}
65-
6647
}

hibernate-core/src/main/java/org/hibernate/sql/model/internal/MutationOperationGroupSingle.java

Lines changed: 7 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,6 @@
66
*/
77
package org.hibernate.sql.model.internal;
88

9-
import java.util.Collections;
10-
import java.util.List;
11-
import java.util.function.BiConsumer;
12-
import java.util.function.BiFunction;
13-
149
import org.hibernate.sql.model.MutationOperation;
1510
import org.hibernate.sql.model.MutationTarget;
1611
import org.hibernate.sql.model.MutationType;
@@ -26,7 +21,10 @@ public class MutationOperationGroupSingle extends AbstractMutationOperationGroup
2621

2722
private final JdbcMutationOperation operation;
2823

29-
public MutationOperationGroupSingle(MutationType mutationType, MutationTarget<?> mutationTarget, JdbcMutationOperation operation) {
24+
public MutationOperationGroupSingle(
25+
MutationType mutationType,
26+
MutationTarget<?> mutationTarget,
27+
JdbcMutationOperation operation) {
3028
super( mutationType, mutationTarget );
3129
this.operation = operation;
3230
}
@@ -47,15 +45,12 @@ public JdbcMutationOperation getSingleOperation() {
4745

4846
@Override
4947
public MutationOperation getOperation(int idx) {
50-
if ( idx != 0 ) throw new IndexOutOfBoundsException( idx );
48+
if ( idx != 0 ) {
49+
throw new IndexOutOfBoundsException( idx );
50+
}
5151
return operation;
5252
}
5353

54-
@Override
55-
public List<MutationOperation> getOperations() {
56-
return Collections.singletonList( operation );
57-
}
58-
5954
@Override
6055
public MutationOperation getOperation(String tableName) {
6156
if ( !tableName.equals( operation.getTableDetails().getTableName() ) ) {
@@ -69,14 +64,4 @@ public MutationOperation getOperation(String tableName) {
6964
return operation;
7065
}
7166

72-
@Override
73-
public void forEachOperation(BiConsumer<Integer, MutationOperation> action) {
74-
action.accept( 0, operation );
75-
}
76-
77-
@Override
78-
public boolean hasMatching(BiFunction<Integer, MutationOperation, Boolean> matcher) {
79-
return matcher.apply( 0, operation );
80-
}
81-
8267
}

hibernate-core/src/main/java/org/hibernate/sql/model/internal/MutationOperationGroupStandard.java

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
import java.util.List;
1010
import java.util.Locale;
11-
import java.util.function.BiConsumer;
12-
import java.util.function.BiFunction;
1311

1412
import org.hibernate.sql.model.MutationOperation;
1513
import org.hibernate.sql.model.MutationTarget;
@@ -51,11 +49,6 @@ public MutationOperation getOperation(int idx) {
5149
return operations.get( idx );
5250
}
5351

54-
@Override
55-
public List<MutationOperation> getOperations() {
56-
return operations;
57-
}
58-
5952
@Override
6053
public MutationOperation getOperation(String tableName) {
6154
for ( int i = 0; i < operations.size(); i++ ) {
@@ -67,20 +60,4 @@ public MutationOperation getOperation(String tableName) {
6760
return null;
6861
}
6962

70-
@Override
71-
public void forEachOperation(BiConsumer<Integer, MutationOperation> action) {
72-
for ( int i = 0; i < operations.size(); i++ ) {
73-
action.accept( i, operations.get( i ) );
74-
}
75-
}
76-
77-
@Override
78-
public boolean hasMatching(BiFunction<Integer, MutationOperation, Boolean> matcher) {
79-
for ( int i = 0; i < operations.size(); i++ ) {
80-
if ( matcher.apply( i, operations.get( i ) ) ) {
81-
return true;
82-
}
83-
}
84-
return false;
85-
}
8663
}

0 commit comments

Comments
 (0)